-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.yaml for carpentries lab transition #128
Conversation
- lesson changed to stable status - carpentry changed from incubator to lab - source changed to point to the new repository URL (before the transfer to carpentries-lab organisation though)
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-lab/good-enough-practices/compare/md-outputs..md-outputs-PR-128 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-09-07 11:54:47 +0000 |
@tobyhodges I'm requesting review on this now we've migrated to carpentries-lab, thank you! Do we have the metadata right? I seem to have something wrong in my local preview that the etherpad template and teaching guide aren't coming up. Does anyone know how to fix that? I requested review from @alee for that reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to config.yaml
are exactly what's needed. To get your extra pages for Instructors to show up in the menu, set a title
for them in the YAML header of their Markdown source files.
Auto-generated via {sandpaper} Source : a8844da Branch : main Author : Edward Wallace <[email protected]> Time : 2023-09-07 11:59:21 +0000 Message : Merge pull request #128 from carpentries-lab/124-config-lab - Update config.yaml for carpentries lab transition - Add titles to instructor materials Thank you @tobyhodges, that was an easy fix. Merging now.
Auto-generated via {sandpaper} Source : f727bb2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-07 12:01:04 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : a8844da Branch : main Author : Edward Wallace <[email protected]> Time : 2023-09-07 11:59:21 +0000 Message : Merge pull request #128 from carpentries-lab/124-config-lab - Update config.yaml for carpentries lab transition - Add titles to instructor materials Thank you @tobyhodges, that was an easy fix. Merging now.
Auto-generated via {sandpaper} Source : f727bb2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-07 12:01:04 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : a8844da Branch : main Author : Edward Wallace <[email protected]> Time : 2023-09-07 11:59:21 +0000 Message : Merge pull request #128 from carpentries-lab/124-config-lab - Update config.yaml for carpentries lab transition - Add titles to instructor materials Thank you @tobyhodges, that was an easy fix. Merging now.
Auto-generated via {sandpaper} Source : f727bb2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-07 12:01:04 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : a8844da Branch : main Author : Edward Wallace <[email protected]> Time : 2023-09-07 11:59:21 +0000 Message : Merge pull request #128 from carpentries-lab/124-config-lab - Update config.yaml for carpentries lab transition - Add titles to instructor materials Thank you @tobyhodges, that was an easy fix. Merging now.
created as draft as should be updated/completed after move to carpentries-lab